[PATCH] D23234: [Coroutines] Part 5: Add CGSCC restart trigger

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM w/ nits addressed.


================
Comment at: lib/Transforms/Coroutines/CoroElide.cpp:17
@@ -16,3 +16,3 @@
 #include "llvm/Analysis/InstructionSimplify.h"
 #include "llvm/IR/ConstantFolder.h"
 #include "llvm/IR/InstIterator.h"
----------------
Could we remove this include?

================
Comment at: lib/Transforms/Coroutines/CoroInternal.h:36
@@ +35,3 @@
+
+#define CORO_ATTR_STR "coroutine.presplit"
+#define CORO_ATTR_VALUE_NOT_READY_FOR_SPLIT "0"
----------------
I'd name this define `CORO_PRESPLIT_ATTR`.

================
Comment at: lib/Transforms/Coroutines/CoroInternal.h:37-38
@@ +36,4 @@
+#define CORO_ATTR_STR "coroutine.presplit"
+#define CORO_ATTR_VALUE_NOT_READY_FOR_SPLIT "0"
+#define CORO_ATTR_VALUE_READY_FOR_SPLIT "1"
+
----------------
Maybe just `PREPARED_FOR_SPLIT` and `UNPREPARED_FOR_SPLIT` ?

================
Comment at: lib/Transforms/Coroutines/CoroSplit.cpp:15
@@ -14,2 +14,3 @@
 #include "llvm/Analysis/CallGraphSCCPass.h"
+#include "llvm/IR/InstIterator.h"
 
----------------
Are you using this? I cannot quite see where...


https://reviews.llvm.org/D23234