[PATCH] D23233: [libunwind] Allow building both shared and static library

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 6 10:16:33 PDT 2016


compnerd accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: src/CMakeLists.txt:101
@@ +100,3 @@
+set_target_properties(unwind_objects
+  PROPERTIES
+    COMPILE_FLAGS "${LIBUNWIND_COMPILE_FLAGS}"
----------------
Please indent this to align up to the arguments as it was previously.

================
Comment at: src/CMakeLists.txt:112
@@ +111,3 @@
+  set_target_properties(unwind_shared
+    PROPERTIES
+      LINK_FLAGS    "${LIBUNWIND_LINK_FLAGS}"
----------------
Similar.

================
Comment at: src/CMakeLists.txt:126
@@ +125,3 @@
+  set_target_properties(unwind_static
+    PROPERTIES
+      LINK_FLAGS    "${LIBUNWIND_LINK_FLAGS}"
----------------
Similar.


Repository:
  rL LLVM

https://reviews.llvm.org/D23233





More information about the llvm-commits mailing list