[PATCH] D22143: [SimplifyCFG] Rewrite SinkThenElseCodeToEnd

Sat Aug 6 03:59:36 PDT 2016

jmolloy updated this revision to Diff 67072.
jmolloy marked an inline comment as done.
jmolloy added a comment.

Thanks Sanjoy. Sorry for not addressing those; must have got a bit lost in the "comment soup".

Addressed, and after extra testing I've discovered we could be sinking GEPs and replacing an operand that must be constant with a variable (struct indexing) so I've fixed that and added a testcase.

Repository:
  rL LLVM

https://reviews.llvm.org/D22143

Files:
  lib/Transforms/Utils/SimplifyCFG.cpp
  test/CodeGen/ARM/avoid-cpsr-rmw.ll
  test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll
  test/Transforms/SimplifyCFG/AArch64/prefer-fma.ll
  test/Transforms/SimplifyCFG/sink-common-code.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22143.67072.patch
Type: text/x-patch
Size: 20994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160806/1f1408fc/attachment.bin>