[PATCH] D23234: [Coroutines] Part 5: Add CGSCC restart trigger

Gor Nishanov via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 21:56:55 PDT 2016


GorNishanov created this revision.
GorNishanov added reviewers: mehdi_amini, majnemer.
GorNishanov added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

CoroSplit pass processes the coroutine twice. First, it lets it go through 
complete IPO optimization pipeline as a single function. It forces restart 
of the pipeline by inserting an indirect call to an empty function "coro.devirt.trigger" 
which is devirtualized by CoroElide pass that triggers a restart of the pipeline by CGPassManager.
(In later patches, when CoroSplit pass sees the same coroutine the second time, it splits it up,
adds coroutine subfunctions to the SCC to be processed by IPO pipeline.)

Documentation and overview is here: http://llvm.org/docs/Coroutines.html.

Upstreaming sequence (rough plan)
1.Add documentation. (https://reviews.llvm.org/D22603)
2.Add coroutine intrinsics. (https://reviews.llvm.org/D22659)
3.Add empty coroutine passes. (https://reviews.llvm.org/D22847)
4.Add coroutine devirtualization + tests.
ab) Lower coro.resume and coro.destroy (https://reviews.llvm.org/D22998)
c) Do devirtualization (https://reviews.llvm.org/D23229)
5.Add CGSCC restart trigger + tests. <= we are here
6.Add coroutine heap elision + tests.
7.Add the rest of the logic (split into more patches)

https://reviews.llvm.org/D23234

Files:
  include/llvm/IR/Function.h
  lib/Transforms/Coroutines/CoroEarly.cpp
  lib/Transforms/Coroutines/CoroElide.cpp
  lib/Transforms/Coroutines/CoroInstr.h
  lib/Transforms/Coroutines/CoroInternal.h
  lib/Transforms/Coroutines/CoroSplit.cpp
  test/Transforms/Coroutines/restart-trigger.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23234.67063.patch
Type: text/x-patch
Size: 10789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160806/19869fcb/attachment.bin>


More information about the llvm-commits mailing list