[PATCH] D23229: Part 4c: Coroutine Devirtualization: Devirtualize coro.resume and coro.destroy.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 17:50:17 PDT 2016


mehdi_amini added a subscriber: mehdi_amini.

================
Comment at: lib/Transforms/Coroutines/CoroInstr.h:76
@@ +75,3 @@
+  // Info argument of coro.begin is
+  //   fresh out of the front: null ;
+  //   outlined              : {Init, Return, Susp1, Susp2, ...} ;
----------------
`frontend` I guess?

================
Comment at: lib/Transforms/Coroutines/CoroInstr.h:84
@@ +83,3 @@
+  //
+  // After coroutine is split, resume functions are stored in an array constant
+  // refered by this parameter.
----------------
Constant array? Array of constants? I'm not sure what you wanted here but "array constant" doesn't seem right to me.


https://reviews.llvm.org/D23229





More information about the llvm-commits mailing list