[PATCH] D23230: asan/win: Disable a few tests that fail on bots with not a lot of memory.

[Nico Weber via llvm-commits]

thakis created this revision.
thakis added reviewers: rnk, etienneb.
thakis added a subscriber: llvm-commits.
Herald added a subscriber: kubabrecka.

This is very ad-hoc: I just disabled all tests that failed in three runs on some of our Windows bots. Is there some general pattern that matches the tests I'm disabling, and do other tests match that pattern too? Put differently: Are there other similar tests in this file I should disable?

https://reviews.llvm.org/D23230

Files:
  lib/sanitizer_common/tests/sanitizer_allocator_test.cc

Index: lib/sanitizer_common/tests/sanitizer_allocator_test.cc
===================================================================
--- lib/sanitizer_common/tests/sanitizer_allocator_test.cc
+++ lib/sanitizer_common/tests/sanitizer_allocator_test.cc
@@ -163,9 +163,14 @@
   TestSizeClassAllocator<Allocator64>();
 }
 
+// This test can fail on Windows if memory is somewhat full and lit happens
+// to run several large-memory tests at the same time.
+// FIXME: Make it not flaky and reenable.
+#if !SANITIZER_WINDOWS
 TEST(SanitizerCommon, SizeClassAllocator64Dynamic) {
   TestSizeClassAllocator<Allocator64Dynamic>();
 }
+#endif
 
 TEST(SanitizerCommon, SizeClassAllocator64Compact) {
   TestSizeClassAllocator<Allocator64Compact>();
@@ -248,6 +253,9 @@
 }
 
 #if SANITIZER_CAN_USE_ALLOCATOR64
+// These tests can fail on Windows if memory is somewhat full and lit happens
+// to run them all at the same time. FIXME: Make them not flaky and reenable.
+#if !SANITIZER_WINDOWS
 TEST(SanitizerCommon, SizeClassAllocator64GetBlockBegin) {
   SizeClassAllocatorGetBlockBeginStress<Allocator64>();
 }
@@ -260,6 +268,7 @@
 TEST(SanitizerCommon, SizeClassAllocator32CompactGetBlockBegin) {
   SizeClassAllocatorGetBlockBeginStress<Allocator32Compact>();
 }
+#endif
 #endif  // SANITIZER_CAN_USE_ALLOCATOR64
 
 struct TestMapUnmapCallback {
@@ -559,10 +568,15 @@
       SizeClassAllocatorLocalCache<Allocator64> >();
 }
 
+// This test can fail on Windows if memory is somewhat full and lit happens
+// to run several large-memory tests at the same time.
+// FIXME: Make it not flaky and reenable.
+#if !SANITIZER_WINDOWS
 TEST(SanitizerCommon, SizeClassAllocator64DynamicLocalCache) {
   TestSizeClassAllocatorLocalCache<
       SizeClassAllocatorLocalCache<Allocator64Dynamic> >();
 }
+#endif
 
 TEST(SanitizerCommon, SizeClassAllocator64CompactLocalCache) {
   TestSizeClassAllocatorLocalCache<


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23230.67036.patch
Type: text/x-patch
Size: 1891 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160805/d58df2cb/attachment.bin>