[PATCH] D23165: [ELF] - Linkerscript: implement SIZEOF_HEADERS.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 14:43:23 PDT 2016
ruiu added inline comments.
================
Comment at: ELF/LinkerScript.cpp:241
@@ -240,3 +240,3 @@
// Assign addresses as instructed by linker script SECTIONS sub-commands.
- Dot = Out<ELFT>::ElfHeader->getSize() + Out<ELFT>::ProgramHeaders->getSize();
+ Dot = Opt.ManualHeadersSize ? 0 : getSizeOfHeaders();
uintX_t MinVA = std::numeric_limits<uintX_t>::max();
----------------
I do see why you are doing this, but this is pretty obscure. Do we really have to do this?
https://reviews.llvm.org/D23165
More information about the llvm-commits
mailing list