[PATCH] D23075: [IndVarSimplify] Extend trip count instead of truncating IV in LFTR, when original IV does not overflow

[Ehsan Amiri via llvm-commits]

amehsan added a comment.

In https://reviews.llvm.org/D23075#507441, @sanjoy wrote:

> Code-wise only minor comments, otherwise the code lgtm.
>
> Test-wise, you really need a few specific test cases for the code you've added (and one or two negative tests).  Even if the code is being exercised as part of other tests, it is nicer to have commits come with test cases that document what new functionality was added.


Yes, I meant to add testcases, but I forgot. Will add.

> You also need to not use grep in the test cases.  Note: I've fixed all of the IndVarSimplify tests to not use grep.


OK. I did not realize there is a recent change in the testcases. Will modify that.


https://reviews.llvm.org/D23075