[PATCH] D23222: Changed sign of LastCallToStaticBouns

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 13:34:36 PDT 2016


eraman added inline comments.

================
Comment at: lib/Analysis/InlineCost.cpp:1261
@@ -1260,3 +1260,3 @@
   if (OnlyOneCallAndLocalLinkage)
-    Cost += InlineConstants::LastCallToStaticBonus;
+    Cost -= InlineConstants::LastCallToStaticBonus;
 
----------------
This is not the only use of this constant - it is used in Inliner.cpp also. It also feels a bit odd to subtract a "bonus", but I have no strong opinions. 


https://reviews.llvm.org/D23222





More information about the llvm-commits mailing list