[PATCH] D23223: [InstCombine] refactor ctlz/cttz folds (NFCI)

[Sanjay Patel via llvm-commits]

spatel created this revision.
spatel added reviewers: deadalnix, majnemer.
spatel added a subscriber: llvm-commits.
Herald added a subscriber: mcrosier.

I suggested this change in D23134, but it was not expressed clearly enough. Maybe reading the code is easier? :)

The existing transforms for ctlz/cttz are almost identical, and the code is obviously copy/pasted. 

We just need to shift the mask over for ctlz to see if our operand gives us a known constant value.

I've also added the FIXME comment that I suggested because I think this (and several other existing transforms in this file) could be moved to InstSimplify.

https://reviews.llvm.org/D23223

Files:
  lib/Transforms/InstCombine/InstCombineCalls.cpp

Index: lib/Transforms/InstCombine/InstCombineCalls.cpp
===================================================================
--- lib/Transforms/InstCombine/InstCombineCalls.cpp
+++ lib/Transforms/InstCombine/InstCombineCalls.cpp
@@ -1104,6 +1104,34 @@
   return nullptr;
 }
 
+static Value *foldCttzCtlz(IntrinsicInst &II, InstCombiner &IC, bool IsTZ) {
+  // FIXME: Try to simplify vectors of integers.
+  IntegerType *IT = dyn_cast<IntegerType>(II.getArgOperand(0)->getType());
+  if (!IT)
+    return nullptr;
+
+  unsigned BitWidth = IT->getBitWidth();
+  APInt KnownZero(BitWidth, 0);
+  APInt KnownOne(BitWidth, 0);
+  IC.computeKnownBits(II.getArgOperand(0), KnownZero, KnownOne, 0, &II);
+
+  // Create a mask for bits above (ctlz) or below (cttz) the first known one.
+  unsigned NumMaskBits =
+      IsTZ ? KnownOne.countTrailingZeros() : KnownOne.countLeadingZeros();
+  APInt Mask(APInt::getLowBitsSet(BitWidth, NumMaskBits));
+  if (!IsTZ)
+    Mask = Mask.shl(BitWidth - NumMaskBits);
+
+  // If all bits above (ctlz) or below (cttz) the first known one are known
+  // zero, this value is constant.
+  // FIXME: This should be in InstSimplify because we're replacing an
+  // instruction with a constant.
+  if ((Mask & KnownZero) == Mask)
+    return ConstantInt::get(IT, APInt(BitWidth, NumMaskBits));
+
+  return nullptr;
+}
+
 // TODO: If the x86 backend knew how to convert a bool vector mask back to an
 // XMM register mask efficiently, we could transform all x86 masked intrinsics
 // to LLVM masked intrinsics and remove the x86 masked intrinsic defs.
@@ -1397,41 +1425,14 @@
                                           II->getArgOperand(0));
     }
     break;
-  case Intrinsic::cttz: {
-    // If all bits below the first known one are known zero,
-    // this value is constant.
-    IntegerType *IT = dyn_cast<IntegerType>(II->getArgOperand(0)->getType());
-    // FIXME: Try to simplify vectors of integers.
-    if (!IT) break;
-    uint32_t BitWidth = IT->getBitWidth();
-    APInt KnownZero(BitWidth, 0);
-    APInt KnownOne(BitWidth, 0);
-    computeKnownBits(II->getArgOperand(0), KnownZero, KnownOne, 0, II);
-    unsigned TrailingZeros = KnownOne.countTrailingZeros();
-    APInt Mask(APInt::getLowBitsSet(BitWidth, TrailingZeros));
-    if ((Mask & KnownZero) == Mask)
-      return replaceInstUsesWith(CI, ConstantInt::get(IT,
-                                 APInt(BitWidth, TrailingZeros)));
 
-    }
+  case Intrinsic::cttz:
+    if (Value *V = foldCttzCtlz(*II, *this, true))
+      return replaceInstUsesWith(*II, V);
     break;
-  case Intrinsic::ctlz: {
-    // If all bits above the first known one are known zero,
-    // this value is constant.
-    IntegerType *IT = dyn_cast<IntegerType>(II->getArgOperand(0)->getType());
-    // FIXME: Try to simplify vectors of integers.
-    if (!IT) break;
-    uint32_t BitWidth = IT->getBitWidth();
-    APInt KnownZero(BitWidth, 0);
-    APInt KnownOne(BitWidth, 0);
-    computeKnownBits(II->getArgOperand(0), KnownZero, KnownOne, 0, II);
-    unsigned LeadingZeros = KnownOne.countLeadingZeros();
-    APInt Mask(APInt::getHighBitsSet(BitWidth, LeadingZeros));
-    if ((Mask & KnownZero) == Mask)
-      return replaceInstUsesWith(CI, ConstantInt::get(IT,
-                                 APInt(BitWidth, LeadingZeros)));
-
-    }
+  case Intrinsic::ctlz:
+    if (Value *V = foldCttzCtlz(*II, *this, false))
+      return replaceInstUsesWith(*II, V);
     break;
 
   case Intrinsic::uadd_with_overflow:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23223.67004.patch
Type: text/x-patch
Size: 3500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160805/7bc988df/attachment.bin>