[llvm] r277857 - Update outdated comments in the new PM internals (NFC)
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 12:51:00 PDT 2016
Author: mehdi_amini
Date: Fri Aug 5 14:51:00 2016
New Revision: 277857
URL: http://llvm.org/viewvc/llvm-project?rev=277857&view=rev
Log:
Update outdated comments in the new PM internals (NFC)
The analysis manager was made not optional and turned into a
reference instead of a pointer in r272978. Some comments were
still refering to the previous behavior.
Modified:
llvm/trunk/include/llvm/IR/PassManagerInternal.h
Modified: llvm/trunk/include/llvm/IR/PassManagerInternal.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManagerInternal.h?rev=277857&r1=277856&r2=277857&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/PassManagerInternal.h (original)
+++ llvm/trunk/include/llvm/IR/PassManagerInternal.h Fri Aug 5 14:51:00 2016
@@ -36,10 +36,6 @@ template <typename IRUnitT> struct PassC
virtual ~PassConcept() {}
/// \brief The polymorphic API which runs the pass over a given IR entity.
- ///
- /// Note that actual pass object can omit the analysis manager argument if
- /// desired. Also that the analysis manager may be null if there is no
- /// analysis manager in the pass pipeline.
virtual PreservedAnalyses run(IRUnitT &IR, AnalysisManager<IRUnitT> &AM) = 0;
/// \brief Polymorphic method to access the name of a pass.
@@ -50,7 +46,7 @@ template <typename IRUnitT> struct PassC
///
/// Can be instantiated for any object which provides a \c run method accepting
/// an \c IRUnitT& and an \c AnalysisManager<IRUnit>&. It requires the pass to
-/// be a copyable object. When the
+/// be a copyable object.
template <typename IRUnitT, typename PassT,
typename PreservedAnalysesT = PreservedAnalyses>
struct PassModel : PassConcept<IRUnitT> {
More information about the llvm-commits
mailing list