[PATCH] D23186: [sanitizers] trace buffer API to use user-allocated buffer.

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 11:35:31 PDT 2016


aizatsky added inline comments.

================
Comment at: include/sanitizer/coverage_interface.h:67
@@ +66,3 @@
+  // Number of pcs recorded in the buffer.
+  // Reset by __sanitizer_reset_coverage();
+  uintptr_t __sanitizer_get_coverage_pc_buffer_pos();
----------------
kcc wrote:
> Is this really what you want? 
> Why do you need to reset the entire coverage just to rest the pc_buffer? 
> Sounds like an overkill. 
I don't have a separate counter for the length at this point. I'm using the same counter that is already available because I don't want to add more synchronization. Quite easy to add though. WDYT?


https://reviews.llvm.org/D23186





More information about the llvm-commits mailing list