[PATCH] D23195: [ARM] Add support for embedded position-independent code

Weiming Zhao via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 10:24:49 PDT 2016


weimingz added a comment.

Thanks Oliver!

I reviewed the ARMISelLowering part and it LGTM.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:728
@@ -727,2 +727,3 @@
 
+  // RW data addressing
   if (isPositionIndependent()) {
----------------
Nitpick: period at end of comment? same for line 738, 744 etc.


https://reviews.llvm.org/D23195





More information about the llvm-commits mailing list