[PATCH] D23102: [ADCE] Refactoring for new functionality (NFC)

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Transforms/Scalar/ADCE.cpp:93-95
@@ +92,5 @@
+  if (isa<TerminatorInst>(I) || I.isEHPad() || I.mayHaveSideEffects()) {
+    // Skip any value profile instrumentation calls if they are
+    // instrumenting constants.
+    if (!isInstrumentsConstant(I))
+      return true;
----------------
david2050 wrote:
> I tried to reply via email but it got lost in space. I prefer to not make this change until I get the my changes landed just for stability of baseline. But I will get to to it before we are done.
Sure, sounds reasonable to me.


https://reviews.llvm.org/D23102