[PATCH] D23176: [LoopVectorizer] Fixed a bug in memory conflict run-time check

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 10:06:24 PDT 2016


anemet added a comment.

In https://reviews.llvm.org/D23176#506707, @delena wrote:

> In https://reviews.llvm.org/D23176#506572, @anemet wrote:
>
> > Did you forget to add the test?
>
>
> No, I didn't. I fixed the existing lit tests that explore the change. Do you want one more lit test?
>  The test case that triggered the bug will not be vectorized without the second patch https://reviews.llvm.org/D20789.


Yes, please.  I would certainly like to have the testcase included in the patch that triggers the bug with an explanation why.  You should be able to construct a testcase by checking the memcheck part of the output of LAA.

Once the other bug is fixed you can add an additional RUN line for -loop-vectorize and then check the compares directly.


Repository:
  rL LLVM

https://reviews.llvm.org/D23176





More information about the llvm-commits mailing list