[PATCH] D23156: [ADT] Stop trying to test every combination of values in a triple in every permutation.
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 08:43:30 PDT 2016
rengolin added a comment.
In https://reviews.llvm.org/D23156#506905, @chandlerc wrote:
> In https://reviews.llvm.org/D23156#506829, @rengolin wrote:
>
> > I'm still looking at the code and the comments, but wouldn't it be enough for 99% of the cases to test it against "unknown" on all other fields? I mean, there are a few problematic combinations, but they require specialised knowledge, and neither the old test (nor the new one) are checking them.
>
>
> I think that's exactly what the patch does?
Dang! That's what I get for commenting before really reading the patch... :)
https://reviews.llvm.org/D23156
More information about the llvm-commits
mailing list