[PATCH] D23154: [compiler-rt][XRay] Implement __xray_unpatch() and __xray_remove_handler()

[Dean Michael Berris via llvm-commits]

dberris added inline comments.

================
Comment at: lib/xray/xray_interface.cc:115
@@ -106,3 +114,3 @@
 
-XRayPatchingStatus __xray_patch() {
+XRayPatchingStatus PatchCommon(bool Patching) {
   if (!XRayInitialized.load(std::memory_order_acquire))
----------------
rSerge wrote:
> It may need a comment on what it does and what the parameter means. Or better, to make the code self-explaining, can it be renamed to e.g. ControlPatching or ControlTracing with a parameter like "bool Enabled"?
Thanks, did both -- added a comment and renamed as you suggested.


https://reviews.llvm.org/D23154