[PATCH] D23185: [sanitizers] trace buffer API to use user-allocated buffer.

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 18:06:56 PDT 2016


vitalybuka added a comment.

LGTM


================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:59
@@ +58,3 @@
+ public:
+  CoverageController(const FuzzingOptions &Options) 
+    : Options(Options), PcBuffer(nullptr), PcBufferLen(0) {
----------------
explicit?

================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:141
@@ +140,3 @@
+ private:
+  const FuzzingOptions Options;
+  uintptr_t* PcBuffer;
----------------
defaults inline here?


https://reviews.llvm.org/D23185





More information about the llvm-commits mailing list