[PATCH] D23149: Printing imported functions size

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 16:10:05 PDT 2016


tejohnson added a comment.

In https://reviews.llvm.org/D23149#506346, @mehdi_amini wrote:

> There is no motivation in the description so it is unclear to me right now. Since the information is already in the summary, having the statistic with a function name already enables you to retrieve this from the combined index.
>  Ultimately it is not scalable to duplicate every information contained by the summary as metadata as you need them.


Right, I was originally thinking about suggesting an alternative which is to pass the index into the inliner so the info could simply be queried directly out of the index. However, it makes dumping these stats via something like "llvm-link -thinlto-action=import | opt -O2" impossible unless we pass the combined index in to opt as well, for passing to the inliner.


https://reviews.llvm.org/D23149





More information about the llvm-commits mailing list