[PATCH] D23177: [CodeView] Decouple the type record deserialization from the visitor.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 14:48:26 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:282
@@ -282,3 +281,3 @@
 
-void error(std::error_code EC) {
-  if (!EC)
+void error(std::error_code ec) {
+  if (!ec)
----------------
ec -> EC

================
Comment at: tools/llvm-readobj/llvm-readobj.h:26
@@ -25,2 +25,3 @@
   LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg);
+  void error(llvm::Error ec);
   void error(std::error_code ec);
----------------
EC


https://reviews.llvm.org/D23177





More information about the llvm-commits mailing list