[PATCH] D23174: GVN-hoist: fix early exit logic
Sebastian Pop via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 13:44:46 PDT 2016
sebpop added inline comments.
================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:897
@@ +896,3 @@
+ // Also do not bother analyzing the following kinds of instructions.
+ if (!isa<TerminatorInst>(&I1))
+ II.insert(&I1, VN);
----------------
dberlin wrote:
> I hope this is not a correctness fix :)
Nop. This is a compilation time fix: as I was saying in the commit message, we should not try to analyze to hoist this kind of "scalar instructions".
https://reviews.llvm.org/D23174
More information about the llvm-commits
mailing list