[PATCH] D22998: [coroutines] Part 4a: Coroutine Devirtualization: Lower coro.resume and coro.destroy.
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 13:12:30 PDT 2016
majnemer added a comment.
LGTM w/ nits addressed.
================
Comment at: lib/Transforms/Coroutines/Coroutines.cpp:99
@@ +98,3 @@
+#ifndef NDEBUG
+static bool IsCoroutineIntrinsicName(StringRef Name) {
+ // NOTE: Must be sorted!
----------------
Functions start with a lower case letter.
================
Comment at: lib/Transforms/Coroutines/Coroutines.cpp:122-124
@@ +121,5 @@
+// that names are intrinsic names.
+bool coro::LowererBase::declaresIntrinsics(Module &M,
+ std::initializer_list<StringRef> List) {
+
+ for (StringRef Name : List) {
----------------
Please clang-format this.
https://reviews.llvm.org/D22998
More information about the llvm-commits
mailing list