[PATCH] D22683: [ELF] Symbol assignment within input section list

[Rafael Espíndola via llvm-commits]

On 4 August 2016 at 16:02, Eugene Leviant <evgeny.leviant at gmail.com> wrote:
> evgeny777 added inline comments.
>
> ================
> Comment at: ELF/LinkerScript.cpp:47
> @@ +46,3 @@
> +template <class ELFT>
> +static inline Symbol *addSymbolToSymtabAux(StringRef Name, uint8_t StOther) {
> +  return Symtab<ELFT>::X->addRegular(Name, STB_GLOBAL, StOther);
> ----------------
> rafael wrote:
>> You don't need the inline.
> Just curious - why?

It has no semantic value. Unless there is a benchmark showing that we
need it we shouldn't keep it.

Cheers,
Rafael