[PATCH] D23056: Adding test for DIMacro and DIMacroFile comparison implementation
Amjad Aboud via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 08:55:15 PDT 2016
aaboud added a comment.
> Side note: Is there any reason we're creating DIMacroFiles that have no macros in them? Or are they unnecessary?
1. GCC does that too.
2. It is implementation details, because we create the DIMacroFile before we parse its content, thus at that point we do not know if it will contain macros or not.
https://reviews.llvm.org/D23056
More information about the llvm-commits
mailing list