[PATCH] D23097: RegScavenging: Add scavengeRegisterBackwards()

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 08:46:30 PDT 2016


uweigand added a comment.

I haven't looked at the PowerPC failures.   However, the changes you're doing to the SystemZ test cases seem already incorrect.

Those tests all verify an instruction sequence that originally looks like:

  spill REGISTER to the stack
  def REGISTER
  use REGISTER
  restore REGISTER from stack

You change them to do instead:

  spill REGISTER to the stack
  def REGISTER
  restore REGISTER from stack
  use REGISTER

which means of course that the use now gets the wrong register contents ...

Am I missing something here?


Repository:
  rL LLVM

https://reviews.llvm.org/D23097





More information about the llvm-commits mailing list