[PATCH] D23140: Split InputSectionDescription::Sort into SortInner and SortOuter.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 07:09:45 PDT 2016
grimar added inline comments.
================
Comment at: ELF/LinkerScript.cpp:752
@@ -756,1 +751,3 @@
+ if (SortKind K2 = readSortKind()) {
+ Cmd->SortInner = K2;
expect("(");
----------------
grimar wrote:
> May be something like:
>
> if (K1 != K2)
> Cmd->SortInner = K2;
>
> to avoid double sorting when the same rule is specified twice:
> SORT_BY_NAME (SORT_BY_NAME(...))
Though it seems to be useless cornercase and we probably should not really care, preferring shorter code.
https://reviews.llvm.org/D23140
More information about the llvm-commits
mailing list