[llvm] r277690 - Revert "GVN-hoist: enable by default" & "Make GVN Hoisting obey optnone/bisect."

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 06:10:04 PDT 2016


I am looking at this fail.
I think I have enough information from the bot on how to reproduce the bug.

On Thu, Aug 4, 2016 at 12:44 AM, Daniel Berlin <dberlin at dberlin.org> wrote:
>
>
> On Wed, Aug 3, 2016 at 10:17 PM, Bruno Cardoso Lopes
> <bruno.cardoso at gmail.com> wrote:
>>
>> Hi Daniel,
>>
>> On Wed, Aug 3, 2016 at 9:59 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
>> > so here's the super-curious question in my mind:
>> >
>> > Why didn't this break when this was enabled by default for like a month
>> > before :)
>>
>> Not really sure why, I was not following the bots back then.
>
>
> Yeah, it's semi-rhetorical. It's just really odd, and makes me think it's
> related to one or more of the optimizations sebastian added (for example,
> not recomputing DFS numbers).
>
>>
>> Where
>> there many changes following up the time it got off? Another
>> possibility is that the bot could have been broken by another change
>> that hid this?
>> I can get my hands on the reproducer and send to you tomorrow if that's
>> helpful.
>>
>
> That would be really helpful.
>
>>
>> -Bruno
>>
>> --
>> Bruno Cardoso Lopes
>> http://www.brunocardoso.cc
>
>


More information about the llvm-commits mailing list