[llvm] r277642 - Revert "[CloneFunction] Don't remove side effecting calls"

[Renato Golin via llvm-commits]

On 3 August 2016 at 21:01, Reid Kleckner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: rnk
> Date: Wed Aug  3 15:01:01 2016
> New Revision: 277642
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277642&view=rev
> Log:
> Revert "[CloneFunction] Don't remove side effecting calls"
>
> This reverts commit r277611 and the followup r277614.
>
> Bootstrap builds and chromium builds are crashing during inlining after
> this change.

Hi Reid,

FYI, I strongly suspect the original commit also broke ARM's self-hosting:

http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/7506
http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/3836

which got fixed with your revert:

http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/3838
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/7508

cheers,
--renato