[PATCH] D23106: [Profile] introduce interface __llvm_profile_dump

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.

================
Comment at: lib/profile/InstrProfiling.h:135
@@ +134,3 @@
+ *
+ *  It is expected that on-line profile merging is on. If merging is
+ *  not turned on, user is expected to invoke __llvm_profile_set_filename
----------------
I don't think it is clear to the user what "on-line profile merging is on" means. AFAIK, currently that implicitly gets turned on based on the filename.
Maybe it would be clearer to say that "the filename must contain a %m specifier"? (possibly in addition to what you already have).


https://reviews.llvm.org/D23106