[PATCH] D23100: [wasm] Fix FastISel generating NoReg
Derek Schuff via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 3 15:52:37 PDT 2016
dschuff added inline comments.
================
Comment at: test/CodeGen/WebAssembly/noreg.ll:3
@@ +2,3 @@
+
+; Test that NoReg is handled correctly by FastISel
+
----------------
dschuff wrote:
> This description doesn't really make sense; the fact that NoReg operands are generated is the bug. Really what is happening is that there are parts that cannot be selected by fast-isel but it doesn't properly bail out.
Oh, probably the corollary to "fix the comment to say what the tested condition and expected result is" would also be to change the name of the test file to something that reflects the tested condition.
https://reviews.llvm.org/D23100
More information about the llvm-commits
mailing list