[PATCH] D22975: Compute the Newton series natively

[Sanjay Patel via llvm-commits]

spatel added inline comments.

================
Comment at: llvm/test/CodeGen/X86/sqrt-fastmath.ll:42-45
@@ -41,6 +41,6 @@
 ; ESTIMATE-NEXT:    vmulss %xmm1, %xmm2, %xmm1
-; ESTIMATE-NEXT:    vxorps %xmm2, %xmm2, %xmm2
-; ESTIMATE-NEXT:    vcmpeqss %xmm2, %xmm0, %xmm0
-; ESTIMATE-NEXT:    vandnps %xmm1, %xmm0, %xmm0
-; ESTIMATE-NEXT:    retq
+; ESTIMATE:         vxorps %xmm2, %xmm2, %xmm2
+; ESTIMATE:         vcmpeqss %xmm2, %xmm0, %xmm2
+; ESTIMATE:         vblendvps %xmm2, %xmm0, %xmm1, %xmm0
+; ESTIMATE:         retq
   %call = tail call float @__sqrtf_finite(float %f) #1
----------------
vblendvps is a regression vs. the vandnps that we had. Do you know what caused that?

Also, why did the "-NEXT" part of the assertions disappear? For any x86 codegen test changes, please use the script that is noted on the first line of the test file to avoid that problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D22975