[PATCH] D22683: [ELF] Symbol assignment within input section list

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 14:16:35 PDT 2016


Davide, it was actually Rui suggestion (look at review comments). He wanted
to remove the code which handled special case, when output section
contained symbols, but didn't contain any input section.
I personally don't mind bringing that code back again.

2016-08-03 21:23 GMT+03:00 Davide Italiano <davide at freebsd.org>:

> On Wed, Aug 3, 2016 at 6:21 AM, Eugene Leviant via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> >
> > 2016-08-03 4:47 GMT+03:00 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
> >>
> >> The patch as is crashes on linkerscript-provide-in-section.s. It is ok
> >> to turn into an error if something is wrong, but please don't crash.
> >>
> >> Cheers,
> >> Rafael
> >>
> >
> > Rafael, this patch deletes that test case, it's strange that you've got
> this
> > crash.
> >
>
> Deleting a testcase is seldom, if ever, a good thing to do. What's the
> reason why did you delete it? Rafael noticed it's crashing, so we
> should probably end up fixing that bug as well.
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160804/4edc4314/attachment.html>


More information about the llvm-commits mailing list