[PATCH] D22998: [coroutines] Part 4a: Coroutine Devirtualization: Lower coro.resume and coro.destroy.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 13:30:10 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Transforms/Coroutines/CoroInstr.h:32
@@ +31,3 @@
+#define CORO_DESTROY_STR "llvm.coro.destroy"
+#define CORO_RESUME_STR "llvm.coro.resume"
+
----------------
It is not great to use `#define` in headers, especially public ones.


https://reviews.llvm.org/D22998





More information about the llvm-commits mailing list