[PATCH] D23114: [PM] Introduce a devirtualization iteration layer for the new PM.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 13:12:35 PDT 2016


silvas added a subscriber: silvas.

================
Comment at: include/llvm/Analysis/CGSCCPassManager.h:528
@@ +527,3 @@
+      // Update the SCC if necessary.
+      C = UR.UpdatedC ? UR.UpdatedC : C;
+
----------------
If you update `C` in this assignment, where do you call `AM.invalidate(...)` on the original `C`? (this is needed to downward invalidate any function analyses that might depend on SCC analyses on the original `C`). Is this something you expect the SCC transformation being run by DevirtIteratingWrapper itself to do? It would be nice to see a unittest exhibiting this.


https://reviews.llvm.org/D23114





More information about the llvm-commits mailing list