[PATCH] D23131: AMDGPU: Fix an interaction between WQM and polygon stippling

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 12:59:23 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:224-225
@@ -225,1 +223,4 @@
+    // Go back to exact mode at the end of non-monolithic shader parts.
+    if (MBB.succ_empty() &&
+        !MF.getInfo<SIMachineFunctionInfo>()->returnsVoid()) {
       Blocks[&MBB].OutNeeds = StateExact;
----------------
This seems to be checking that this is a return block. This will be wrong if the block ends in unreachable. Can you add a test with this?


https://reviews.llvm.org/D23131





More information about the llvm-commits mailing list