[PATCH] D23123: lld-link: Include the name of bad input files in several "input file is bad" diagnostics.

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 11:10:22 PDT 2016


thakis added inline comments.

================
Comment at: COFF/InputFiles.cpp:112
@@ -111,3 +111,3 @@
   std::unique_ptr<Binary> Bin =
-      check(createBinary(MB), "failed to parse object file");
+      check(createBinary(MB), getShortName());
 
----------------
ruiu wrote:
> Does the final output message contain something like "failed to parse"?
For this line, previous:
failed to parse object file: The file was not recognized as a valid object file

Now:
out.obj: The file was not recognized as a valid object file

(tested with `touch foo.obj && bin/lld-link foo.obj`)


https://reviews.llvm.org/D23123





More information about the llvm-commits mailing list