[lld] r277594 - Remove redundant argument.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 3 06:21:16 PDT 2016
Author: rafael
Date: Wed Aug 3 08:21:16 2016
New Revision: 277594
URL: http://llvm.org/viewvc/llvm-project?rev=277594&view=rev
Log:
Remove redundant argument.
Modified:
lld/trunk/ELF/LinkerScript.cpp
lld/trunk/ELF/LinkerScript.h
lld/trunk/ELF/Writer.cpp
Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=277594&r1=277593&r2=277594&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Wed Aug 3 08:21:16 2016
@@ -218,9 +218,8 @@ template <class ELFT> void LinkerScript<
}
}
-template <class ELFT>
-void LinkerScript<ELFT>::assignAddresses(
- ArrayRef<OutputSectionBase<ELFT> *> Sections) {
+template <class ELFT> void LinkerScript<ELFT>::assignAddresses() {
+ ArrayRef<OutputSectionBase<ELFT> *> Sections = *OutputSections;
// Orphan sections are sections present in the input files which
// are not explicitly placed into the output file by the linker script.
// We place orphan sections at end of file.
@@ -289,8 +288,8 @@ void LinkerScript<ELFT>::assignAddresses
}
template <class ELFT>
-std::vector<PhdrEntry<ELFT>>
-LinkerScript<ELFT>::createPhdrs(ArrayRef<OutputSectionBase<ELFT> *> Sections) {
+std::vector<PhdrEntry<ELFT>> LinkerScript<ELFT>::createPhdrs() {
+ ArrayRef<OutputSectionBase<ELFT> *> Sections = *OutputSections;
std::vector<PhdrEntry<ELFT>> Ret;
for (const PhdrsCommand &Cmd : Opt.PhdrsCommands) {
Modified: lld/trunk/ELF/LinkerScript.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=277594&r1=277593&r2=277594&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.h (original)
+++ lld/trunk/ELF/LinkerScript.h Wed Aug 3 08:21:16 2016
@@ -133,12 +133,11 @@ public:
void createSections(std::vector<OutputSectionBase<ELFT> *> *Out,
OutputSectionFactory<ELFT> &Factory);
- std::vector<PhdrEntry<ELFT>>
- createPhdrs(ArrayRef<OutputSectionBase<ELFT> *> S);
+ std::vector<PhdrEntry<ELFT>> createPhdrs();
ArrayRef<uint8_t> getFiller(StringRef Name);
bool shouldKeep(InputSectionBase<ELFT> *S);
- void assignAddresses(ArrayRef<OutputSectionBase<ELFT> *> S);
+ void assignAddresses();
int compareSections(StringRef A, StringRef B);
void addScriptedSymbols();
bool hasPhdrsCommands();
Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=277594&r1=277593&r2=277594&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Wed Aug 3 08:21:16 2016
@@ -245,12 +245,11 @@ template <class ELFT> void Writer<ELFT>:
if (Config->Relocatable) {
assignFileOffsets();
} else {
- Phdrs = Script<ELFT>::X->hasPhdrsCommands()
- ? Script<ELFT>::X->createPhdrs(OutputSections)
- : createPhdrs();
+ Phdrs = Script<ELFT>::X->hasPhdrsCommands() ? Script<ELFT>::X->createPhdrs()
+ : createPhdrs();
fixHeaders();
if (ScriptConfig->HasContents) {
- Script<ELFT>::X->assignAddresses(OutputSections);
+ Script<ELFT>::X->assignAddresses();
} else {
fixSectionAlignments();
assignAddresses();
More information about the llvm-commits
mailing list