[PATCH] D22694: [Inliner, OptDiag] Add hotness attribute to opt diagnostics

[Adam Nemet via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D22694#500213, @eraman wrote:

> Yes, I understand that this is a reporting tool and so the compilation time is not a major constraint. I was wondering if this makes it practical for use in real applications. Perhaps it is. Have you run this on anything large (SPEC, for example) and measured the overhead? I don't have any objections to this patch if you have measured the overhead and found them reasonable.


I've run this on SPEC2000_int, SPEC2006_int/fp now and the overhead seems reasonable with a release (no-asserts) compiler.  The worst ones were perlbmk (both 2000 and 2006) and omnetpp around 30% slower.  The differences trail off quickly afterwards.  Also this was done without LTO.  LTO is probably worse.

Let me know if you have further questions.

Adam


https://reviews.llvm.org/D22694