[compiler-rt] r277560 - [compiler-rt] Fix broken interception unittest
Etienne Bergeron via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 19:44:30 PDT 2016
Author: etienneb
Date: Tue Aug 2 21:44:30 2016
New Revision: 277560
URL: http://llvm.org/viewvc/llvm-project?rev=277560&view=rev
Log:
[compiler-rt] Fix broken interception unittest
Summary:
This patch is fixing a broken unittest which make the win64 bot failing.
The bug was introduce here:
https://reviews.llvm.org/D23046
The interception code is not the same in 32-bit and in 64-bit.
The added unittest can only be patched on 32-bits.
Reviewers: rnk
Subscribers: llvm-commits, chrisha
Differential Revision: https://reviews.llvm.org/D23099
Modified:
compiler-rt/trunk/lib/interception/tests/interception_win_test.cc
Modified: compiler-rt/trunk/lib/interception/tests/interception_win_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/interception/tests/interception_win_test.cc?rev=277560&r1=277559&r2=277560&view=diff
==============================================================================
--- compiler-rt/trunk/lib/interception/tests/interception_win_test.cc (original)
+++ compiler-rt/trunk/lib/interception/tests/interception_win_test.cc Tue Aug 2 21:44:30 2016
@@ -481,7 +481,11 @@ TEST(Interception, PatchableFunction) {
EXPECT_TRUE(TestFunctionPatching(kPatchableCode3, override));
#endif
EXPECT_TRUE(TestFunctionPatching(kPatchableCode4, override));
+#if SANITIZER_WINDOWS64
+ EXPECT_FALSE(TestFunctionPatching(kPatchableCode5, override));
+#else
EXPECT_TRUE(TestFunctionPatching(kPatchableCode5, override));
+#endif
EXPECT_FALSE(TestFunctionPatching(kUnpatchableCode1, override));
EXPECT_FALSE(TestFunctionPatching(kUnpatchableCode2, override));
More information about the llvm-commits
mailing list