[PATCH] D22399: [LoopDataPrefetch/AArch64] Don't add prefetch intrinsic, when the loop already has InlineAsm prefetch.
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 17:28:19 PDT 2016
t.p.northover added a comment.
> I am not sure that all users will use ACLE intrinsics instead of inline asm.
They should always use intrinsics when standardized ones are available. Usually even when non-standard ones are. They're strictly more portable than asm, and one of the main reasons we advocate them is precisely because they give the compiler a better idea of what's happening (otherwise we could quite easily have implemented arm_neon.h using inline asm, like GCC).
> I think using inline asm or intrinsic is still user's choice. Because inline asm has much longer history than intrinsic. And there are so many codes which use inline asm.
It's certainly their choice, but one penalty of using asm has always been that the compiler doesn't know what's going on. I'm pretty strongly opposed to changing that.
> Or how about give up inserting prefetch intrinsic when the loop has inline asm?
I could just about live with that.
https://reviews.llvm.org/D22399
More information about the llvm-commits
mailing list