[PATCH] D22987: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)

[Vedant Kumar via llvm-commits]

vsk marked an inline comment as done.

================
Comment at: cmake/modules/AddLLDB.cmake:87-89
@@ -86,6 +86,5 @@
 
-  # Hack: only some LLDB libraries depend on the clang autogenerated headers,
-  # but it is simple enough to make all of LLDB depend on some of those
-  # headers without negatively impacting much of anything.
-  add_dependencies(${name} libclang)
+  foreach(clang_dep IN LISTS ${CLANG_USED_LIBS})
+    add_dependencies(${name} ${clang_dep})
+  endforeach(clang_dep)
 
----------------
zturner wrote:
> I think you can just write:
> 
> ```
> add_dependencies(${name} ${CLANG_USED_LIBS})
> ```
When I try doing this, I get a syntax error:

```
CMake Error at tools/lldb/cmake/modules/AddLLDB.cmake:88 (add_dependencies):
  add_dependencies called with incorrect number of arguments
Call Stack (most recent call first):
  tools/lldb/source/Symbol/CMakeLists.txt:1 (add_lldb_library)
```


https://reviews.llvm.org/D22987