[PATCH] D23073: [LoopVectorize] Change comment for isOutOfScope in collectLoopUniforms, NFC

[Wei Mi via llvm-commits]

wmi added a comment.

Thanks for the review.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4949
@@ -4948,2 +4948,3 @@
   // We now know that the loop is vectorizable!
-  // Collect variables that will remain uniform after vectorization.
+  // Collect variables inside the loop that will remain uniform after
+  // vectorization.
----------------
mkuper wrote:
> As long as you're changing this, can we change "variables" to something more meaningful? Instructions, or perhaps values?
I change variables to instructions.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4952
@@ -4950,3 +4951,3 @@
 
-  // If V is not an instruction inside the current loop, it is a Value
-  // outside of the scope which we are interesting in.
+  // Global value, param or instruction outside of current loop are out of
+  // scope.
----------------
mkuper wrote:
> Maybe "Global values, params and instructions outside of the current loop are"?
Fixed.


Repository:
  rL LLVM

https://reviews.llvm.org/D23073