[PATCH] D22987: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 13:18:29 PDT 2016
zturner added a comment.
Are the timing results the same with this patch and the original patch, or is this one a little bit slower?
================
Comment at: cmake/modules/AddLLDB.cmake:87-89
@@ -86,6 +86,5 @@
- # Hack: only some LLDB libraries depend on the clang autogenerated headers,
- # but it is simple enough to make all of LLDB depend on some of those
- # headers without negatively impacting much of anything.
- add_dependencies(${name} libclang)
+ foreach(clang_dep IN LISTS ${CLANG_USED_LIBS})
+ add_dependencies(${name} ${clang_dep})
+ endforeach(clang_dep)
----------------
I think you can just write:
```
add_dependencies(${name} ${CLANG_USED_LIBS})
```
https://reviews.llvm.org/D22987
More information about the llvm-commits
mailing list