[PATCH] D23018: [sanitizer] Implement a __asan_default_options() equivalent for Scudo

Kostya Kortchinsky via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 12:27:30 PDT 2016


cryptoad added a comment.

In https://reviews.llvm.org/D23018#503660, @kcc wrote:

> Is your choice of the name (getScudoDefaultOptions, w/o "__") deliberate? 
>  With __ you are guaranteed that no user code will have such a name since __ names are reserved for the implementation. 
>  With getScudoDefaultOptions you don't have such guarantee.
>
> Otherwise LG


I couldn't find anything in the coding standards (http://llvm.org/docs/CodingStandards.html) that was covering this case, so I went with the default naming for a function.
If that's acceptable to prefix with __, then I am all for it!


https://reviews.llvm.org/D23018





More information about the llvm-commits mailing list