[PATCH] D23056: Adding test for DIMacro and DIMacroFile comparison implementation
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 09:32:21 PDT 2016
dblaikie added a comment.
Thanks for writing up the test!
Though this looks like a few too many CHECK lines - we usually don't check the entire contents of the output like that, so that the test is resilient to unrelated changes.
Perhaps you could show/attach the output before and after the change, so we could see what particular part changed & decide how to test just that part or the surrounding important parts?
https://reviews.llvm.org/D23056
More information about the llvm-commits
mailing list