[PATCH] D21379: [X86] Heuristic to selectively build Newton-Raphson SQRT estimation

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 09:31:30 PDT 2016


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D21379#503444, @spatel wrote:

> Hal's comment about the MachineCombiner reminded me of the excellent list of FMA loop examples provided by @v_klochkov in:
>  https://reviews.llvm.org/D18751.
>
> Summary: the latency vs. throughput trade-off is tricky even if we defer the decision to a later pass.
>
> LGTM, but Hal can confirm if the added comments are sufficient.


Yes, thanks!


https://reviews.llvm.org/D21379





More information about the llvm-commits mailing list