[PATCH] D22998: [coroutines] Part 4a: Coroutine Devirtualization: Lower coro.resume and coro.destroy.

Gor Nishanov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 08:13:25 PDT 2016


GorNishanov removed rL LLVM as the repository for this revision.
GorNishanov updated this revision to Diff 66479.
GorNishanov added a comment.

Addressed review comments:

1. Wholesale clang-format
2. M/C renamed TheModule/Context
3. kIndex, kFrame renamed IndexArg, FrameArg
4. use {Frame,Index} instead of creating a SmallVector<2, Arg>
5. auto X / auto* X where appropriate
6. Continue using getNamedValue as a way to check if there is any work to do.
7. added assert in makeSubFnCall to check that index is in range
8. use llvm::make_unique
9. s/changed/Changed


https://reviews.llvm.org/D22998

Files:
  lib/Transforms/Coroutines/CoroEarly.cpp
  lib/Transforms/Coroutines/CoroInstr.h
  lib/Transforms/Coroutines/CoroInternal.h
  lib/Transforms/Coroutines/Coroutines.cpp
  test/Transforms/Coroutines/coro-early.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22998.66479.patch
Type: text/x-patch
Size: 9459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160802/df23e4b2/attachment.bin>


More information about the llvm-commits mailing list