[PATCH] D23061: [tsan] Fix the behavior of OSAtomicTestAndClear

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 07:33:55 PDT 2016


dvyukov accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/tsan/rtl/tsan_interceptors_mac.cc:126
@@ -125,3 +125,3 @@
     char *byte_ptr = ((char *)ptr) + (n >> 3);                \
-    char bit_index = n & 7;                                   \
-    char mask = m;                                            \
+    char bit_index = 0x80u >> (n & 7);                        \
+    char mask = clear ? ~bit_index : bit_index;               \
----------------
This is now bit rather than bit_index.


https://reviews.llvm.org/D23061





More information about the llvm-commits mailing list