[PATCH] D22908: [ARM] Improve isel of smul and smla instructions for thumb2
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 03:25:35 PDT 2016
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM with the nit. Thanks!
================
Comment at: lib/Target/ARM/ARMInstrFormats.td:1002
@@ -1001,1 +1001,3 @@
}
+class Thumb2Pat<dag pattern, dag result> : Pat<pattern, result> {
+ list<Predicate> Predicates = [IsThumb2];
----------------
You don't seem to be using the first two. Maybe we shouldn't create them "just to complete the pattern"?
https://reviews.llvm.org/D22908
More information about the llvm-commits
mailing list