[PATCH] D22952: [LoopVectorize] Detect loops in the innermost loop before creating InnerLoopVectorizer

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

In https://reviews.llvm.org/D22952#502880, @anemet wrote:

> Where this check should be is related to PR28374.  I think it should be checked when we initially gather the inner most loops in addInnerLoop.


I'm not sure. I mean, both ways make sense, but the way I see it is the inner-most "loop", in the sense that there are no loops (as opposed to cycles) living inside it. So adding it, and then performing a legality check makes sense to me. 
What's the motivation for doing it in addInnerLoop? I don't see why that would improve reporting, and I think it'd be nicer to leave addInnerLoop straight-forward, and keep all of the negative conditions in the legality check.


https://reviews.llvm.org/D22952